Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gpu device plugin to better support Vulkan workloads #78868

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@chardch
Copy link
Contributor

commented Jun 10, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
Picks up the gpu device plugin up this PR that injects the Vulkan ICD file into containers that request gpus. The Vulkan ICD file is necessary in order to run Vulkan workloads.

Does this PR introduce a user-facing change?:

Mounts /home/kubernetes/bin/nvidia/vulkan/icd.d on the host to /etc/vulkan/icd.d inside containers requesting GPU.
@chardch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

/test pull-kubernetes-integration
/test pull-kubernetes-bazel-test

@chardch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

/cc @jiayingz

@k8s-ci-robot k8s-ci-robot requested a review from jiayingz Jun 12, 2019

@jiayingz
Copy link
Member

left a comment

/lgtm

@chardch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

Hi @roberthbailey, could you take a look at this PR when you have time? Thanks!

@chardch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

/assign @roberthbailey

@yguo0905

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

/assign @mikedanese

Can you please help approve this change? Thanks.

@roberthbailey

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/unassign @roberthbailey

@chardch - sorry, I no longer work on this code base so I don't feel comfortable approving.

@chardch

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

Thanks for letting me know @roberthbailey

@mikedanese

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chardch, mikedanese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f4a62ad into kubernetes:master Jun 25, 2019

23 checks passed

cla/linuxfoundation chardch authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.