Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubectl user exec should accept zero-length environment values #652 #78875

Merged
merged 2 commits into from Jul 25, 2019

Conversation

@pswica
Copy link
Member

commented Jun 10, 2019

What type of PR is this?
/kind feature
What this PR does / why we need it:
Allow blank strings "" as values in users.[].user.exec.env.[].value
Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#652
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Users can now enter blank strings as values in the `users.[].user.exec.env.[].value` section of a kubeconfig file.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 10, 2019

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seans3

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

/ok-to-test

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/priority backlog

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

/assign @lavalamp

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

/assign @roycaihw

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 18, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

@pswica: Reiterating the mentions to trigger a notification:
@kubernetes/sig-cli-pr-reviews

In response to this:

@kubernetes/sig-cli-pr-reviews PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -385,79 +385,76 @@ func TestValidateAuthInfoExec(t *testing.T) {
test.testConfig(t)
}

This comment has been minimized.

Copy link
@asalkeld

asalkeld Jul 18, 2019

Contributor

the moving functions around makes it more difficult than needed to review.

This comment has been minimized.

Copy link
@liggitt

liggitt Jul 25, 2019

Member

agree... please put these back in the previous order so the diff reflects what is actually being changed

@asalkeld
Copy link
Contributor

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 18, 2019

@pswica pswica force-pushed the pswica:652 branch from a2692b8 to 3e75609 Jul 25, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed lgtm size/M labels Jul 25, 2019

@pswica pswica force-pushed the pswica:652 branch from 3e75609 to 9206b61 Jul 25, 2019

@pswica pswica force-pushed the pswica:652 branch from 9206b61 to c055094 Jul 25, 2019

@k8s-ci-robot k8s-ci-robot added size/XS and removed size/S labels Jul 25, 2019

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

Thank you @liggitt @asalkeld I reordered the tests

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f30af9d into kubernetes:master Jul 25, 2019

23 checks passed

cla/linuxfoundation pswica authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

melina added a commit to melina/kubernetes that referenced this pull request Jul 26, 2019

Kubectl user exec should accept zero-length environment values kubern…
…etes#652 (kubernetes#78875)

* Kubectl user exec should accept zero-length environment values kubernetes#652

* Changing TestValidateAuthInfoExecInvalidEnv to allow for empty strings as Exec values

liu-cong added a commit to liu-cong/kubernetes that referenced this pull request Jul 29, 2019

Kubectl user exec should accept zero-length environment values kubern…
…etes#652 (kubernetes#78875)

* Kubectl user exec should accept zero-length environment values kubernetes#652

* Changing TestValidateAuthInfoExecInvalidEnv to allow for empty strings as Exec values

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.