Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
1.15: Fix incorrect procMount defaulting #78885
What this PR does / why we need it:
Fixes incorrect forcing of the alpha procMount field to a non-nil value.
Which issue(s) this PR fixes (optional, in
See similar discussion in #69988 and #69445. The only reason upgrade tests didn't catch this is because the defaulting happened in a nested object that happened to be nil in the upgrade test fixtures.
Special notes for your reviewer:
This PR restores the behavior for this alpha field to the way it was in 1.12 and 1.13, with one change: objects without the alpha field set are allowed to remain nil. This prevents unrelated updates to a workload object (like annotating it) from modifying the pod spec portion of the object and forcing a spurious rollout.
This also updates the fixtures used in the workload upgrade tests that would have caught this issue.
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing