Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.15: Fix incorrect procMount defaulting #78885

Merged
merged 1 commit into from Jun 11, 2019

Conversation

@liggitt
Copy link
Member

commented Jun 11, 2019

What this PR does / why we need it:

Fixes incorrect forcing of the alpha procMount field to a non-nil value.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #78633

See similar discussion in #69988 and #69445. The only reason upgrade tests didn't catch this is because the defaulting happened in a nested object that happened to be nil in the upgrade test fixtures.

Special notes for your reviewer:

This PR restores the behavior for this alpha field to the way it was in 1.12 and 1.13, with one change: objects without the alpha field set are allowed to remain nil. This prevents unrelated updates to a workload object (like annotating it) from modifying the pod spec portion of the object and forcing a spurious rollout.

This also updates the fixtures used in the workload upgrade tests that would have caught this issue.
Similar changes are required in 1.12-1.14.

Release note:

Resolves spurious rollouts of workload controllers when upgrading the API server, due to incorrect defaulting of an alpha procMount field in pods

/sig apps
/cc @janetkuo @smarterclayton
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot requested review from janetkuo and smarterclayton Jun 11, 2019

@liggitt liggitt changed the title Fix incorrect procMount defaulting 1.15: Fix incorrect procMount defaulting Jun 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/retest

@liggitt liggitt added the kind/bug label Jun 11, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/retest

@dims

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

/lgtm
/hold

( for API review, possibly @smarterclayton )

@janetkuo

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

/lgtm

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

/hold cancel
/approve

for api implications

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

pull-kubernetes-e2e-gce-100-performance timeout
/retest

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Jun 11, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 0a9373b into kubernetes:master Jun 11, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@Bubblemelon Bubblemelon referenced this pull request Jun 11, 2019
9 of 9 tasks complete

@liggitt liggitt deleted the liggitt:procmount-1.15 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.