Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to detect default changes to podspec and podspectemplate defaults #78914

Merged
merged 1 commit into from Jun 27, 2019

Conversation

@liggitt
Copy link
Member

commented Jun 11, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adds unit tests to detect changes to defaults:

  • within PodSpec (which causes spurious container restarts on API server upgrade)
  • within PodSpecTemplate (which causes spurious workload rollouts on API server upgrade)

Which issue(s) this PR fixes:
xref #78904
follow up to (and based on) #78885

Special notes for your reviewer:
Only the second test commit needs reviewing.

Does this PR introduce a user-facing change?:

NONE

/sig apps
/cc @smarterclayton

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/milestone v1.16
/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 22, 2019

/assign @janetkuo

@janetkuo
Copy link
Member

left a comment

Nits only and LGTM otherwise. Thanks the tests are very thorough.


legacyscheme.Scheme.Default(obj)
defaultedV := visit.value
// t.Log(visit.path)

This comment has been minimized.

Copy link
@janetkuo

janetkuo Jun 27, 2019

Member

nit: remove this?

@@ -34,6 +37,280 @@ import (
_ "k8s.io/kubernetes/pkg/api/testapi"
)

// TestWorkloadCompatibility detects changes to defaults within PodTemplateSpec.

This comment has been minimized.

Copy link
@janetkuo

janetkuo Jun 27, 2019

Member

nit: TestWorkloadDefaults

@liggitt liggitt force-pushed the liggitt:pod-spec-defaults branch from 8d97cda to 617309c Jun 27, 2019

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

fixed and tagged

@liggitt liggitt added the lgtm label Jun 27, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9c8827f into kubernetes:master Jun 27, 2019

23 checks passed

cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt deleted the liggitt:pod-spec-defaults branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.