Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix iscsi logout issues #78941
What type of PR is this?
What this PR does / why we need it:
Does this PR introduce a user-facing change?:
Jun 12, 2019
2 similar comments
referenced this pull request
Jun 13, 2019
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jsafrane
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
j-griffith left a comment
I think this is "ok" as is, but if you wanted to be sure about the iscsiadm errors I'd suggest just removing the explicit checks for errors being returned, instead just if there is an error check if thing were cleaned up or not.
1 similar comment
@jsafrane: The following tests failed, say