Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.12.6 #78958

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@tao12345666333
Copy link
Contributor

commented Jun 13, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:

go1.12.6 (released 2019/06/11) includes fixes to the compiler, the linker,
the go command, and the crypto/x509, net/http, and
os packages. See the Go 1.12.6 milestone on our issue tracker for details.

golang/go@go1.12.5...go1.12.6

update to go 1.12.6

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update to use go 1.12.6
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from fejta and listx Jun 13, 2019

update to go 1.12.6
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>

@tao12345666333 tao12345666333 force-pushed the tao12345666333:go-1.12.6 branch from f40f99b to 37f091e Jun 13, 2019

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jun 17, 2019

/assign @ixdy @lavalamp PTAL

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

@tao12345666333: GitHub didn't allow me to assign the following users: PTAL.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @ixdy @lavalamp PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@listx

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

/ok-to-test

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jun 18, 2019

W0618 03:38:20.320] Step 1/16 : FROM k8s.gcr.io/kube-cross:v1.12.6-1
W0618 03:38:20.320] manifest for k8s.gcr.io/kube-cross:v1.12.6-1 not found

we need wait for k8s.gcr.io/kube-cross:v1.12.6-1 image be published.
cc @javier-b-perez

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

I'm building now... will post here when the image is ready

@listx

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

FYI there is work going on to try to remove Googlers from the critical path (of publishing images for the community) here: https://github.com/kubernetes-sigs/k8s-container-image-promoter. Hopefully it lands for k8s.gcr.io soon.

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jun 18, 2019

/retest
/LGTM

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

/test pull-kubernetes-bazel-test

@fejta
Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bd35a48 into kubernetes:master Jun 20, 2019

23 checks passed

cla/linuxfoundation tao12345666333 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@tao12345666333 tao12345666333 deleted the tao12345666333:go-1.12.6 branch Jun 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.