Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug that pods not be deleted from unmatched nodes by daemon controller #78974

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@DaiHao
Copy link
Member

commented Jun 13, 2019

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix daemon controller failed to delete pods from all unmatched nodes

here is how this bug happens

Timeline:
t1: add a special label to node1 to let deamon_controller delete its pod
t2: ds-foo enqueue, set exp.del=1, delete pod1;
t3: kubelet begin to clean pod1's containers
t4: informer received pod1 update event and set exp.del=exp.del-1

t5: ds-foo enqueue, pod1 still exists in informer, controller add pod1 to podsToDelete array
t6: informer received pod1 delete event and set exp.del=exp.del-1
t7: controller set exp.del=1, but pod1 has been deleted, so exp will never be satisfied until expired.
t8: exp is not satisfied and controller only update ds's status

Which issue(s) this PR fixes:

Fixes #78972

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix a bug that pods not be deleted from unmatched nodes by daemon controller  
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Hi @DaiHao. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested review from krmayankk and mortent Jun 13, 2019
@DaiHao

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

/assign @janetkuo
/sig apps
/kind bug
/priority important-soon

@DaiHao

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

/assign @k82cn

@k82cn

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

/ok-to-test
/lgtm

@DaiHao

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

/test pull-kubernetes-bazel-build

@DaiHao

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

ping @janetkuo

@janetkuo

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DaiHao, janetkuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1782653 into kubernetes:master Jun 15, 2019
23 checks passed
23 checks passed
cla/linuxfoundation DaiHao authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.