Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl config set hangs on some invalid property names #415 #79000

Merged
merged 1 commit into from Jun 15, 2019

Conversation

@pswica
Copy link
Member

commented Jun 13, 2019

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a bug where kubectl set config hangs and uses 100% CPU on some invalid property names
Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#415
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Fixes a bug where `kubectl set config` hangs and uses 100% CPU on some invalid property names 
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 13, 2019

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

/assign @adohe

@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

/priority backlog

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

thanks for the PR. Can you add a test that would reproduce the error?

@pswica pswica force-pushed the pswica:415 branch from 2b4a4ea to ae386f3 Jun 14, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jun 14, 2019
@pswica

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

@liggitt
Thanks a lot for your feedback. I have added a test and changed the error message a bit.

@adohe

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/ok-to-test

@adohe

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 14, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit af9d54d into kubernetes:master Jun 15, 2019
23 checks passed
23 checks passed
cla/linuxfoundation pswica authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@pswica pswica referenced this pull request Jun 26, 2019
6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.