Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E storage: test snapshot semantics #79015

Open
wants to merge 2 commits into
base: master
from
Open

Conversation

@zhucan
Copy link
Member

zhucan commented Jun 14, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
E2E storage: test snapshot semantics

Which issue(s) this PR fixes:

Fixes #73625

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

E2E storage: test snapshot semantics
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 14, 2019

Welcome @zhucan!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 14, 2019

Hi @zhucan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Jun 14, 2019

/assign @xing-yang

@xing-yang

This comment has been minimized.

Copy link
Contributor

xing-yang commented Jun 18, 2019

/ok-to-test

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jun 19, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Jun 19, 2019

/retest

@k8s-ci-robot k8s-ci-robot added kind/bug and removed needs-kind labels Jun 20, 2019
@zhucan zhucan mentioned this pull request Jun 25, 2019
6 of 6 tasks complete
@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch from 813af7f to ddd46dc Oct 24, 2019
@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch 2 times, most recently from 931455c to e26f278 Oct 24, 2019
@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Oct 24, 2019

/retest

@xing-yang

This comment has been minimized.

Copy link
Contributor

xing-yang commented Oct 25, 2019

@zhucan, please take a look of test failures.

@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch from e26f278 to 02c939e Oct 25, 2019
@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Oct 25, 2019

/retest

@xing-yang

This comment has been minimized.

Copy link
Contributor

xing-yang commented Nov 15, 2019

@zhucan My PR is already merged. Can you rebase against the master?

@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Nov 16, 2019

@xing-yang I will rebase it out of day

@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch from 02c939e to 9ba79ca Nov 22, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Nov 22, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhucan
To complete the pull request process, please assign eparis, saad-ali
You can assign the PR to them by writing /assign @eparis @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch 2 times, most recently from 6e8653b to e4b0945 Nov 22, 2019
@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Nov 22, 2019

/retest

@xing-yang

This comment has been minimized.

Copy link
Contributor

xing-yang commented Dec 12, 2019

@zhucan can you please rebase this PR.

@xing-yang

This comment has been minimized.

Copy link
Contributor

xing-yang commented Dec 12, 2019

Note that my PR is already merged. After rebasing from master, we should not see my PR in this PR any more.

@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Dec 13, 2019

@xing-yang copy that

…ate and update e2e tests
@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch from e4b0945 to c1579f1 Dec 13, 2019
Signed-off-by: zhucan <zhucan.k8s@gmail.com>
@zhucan zhucan force-pushed the zhucan:bugfix-73625 branch from c1579f1 to 6c9d49d Dec 13, 2019
@zhucan

This comment has been minimized.

Copy link
Member Author

zhucan commented Dec 13, 2019

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.