Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make azure disk URI as case insensitive #79020

Merged

Conversation

@andyzhangx
Copy link
Member

commented Jun 14, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
This PR makes the azure disk URI as case insensitive, otherwise there could be error like following if customer ignore the disk URI case:

Error expanding volume "del-me/test-pvc" of plugin kubernetes.io/azure-disk : invalid disk URI: /subscriptions/xxx/resourcegroups/xxx/providers/Microsoft.Compute/disks/Test_Resize_1/”

Which issue(s) this PR fixes:

Fixes #79009

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix: make azure disk URI as case insensitive

/kind bug
/assign @feiskyer
/priority important-soon
/sig azure

@andyzhangx

This comment has been minimized.

Copy link
Member Author

commented Jun 16, 2019

/test pull-kubernetes-kubemark-e2e-gce-big
/test pull-kubernetes-integration

@feiskyer

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer
Copy link
Member

left a comment

lgtm. let's wait a while for CI

@feiskyer feiskyer added this to In progress in SIG Azure via automation Jun 17, 2019

@feiskyer

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9120d42 into kubernetes:master Jun 17, 2019

24 checks passed

cla/linuxfoundation andyzhangx authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-aks-engine-azure Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Azure automation moved this from In progress to Done Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.