Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SECURITY.md for GitHub security policy page #79050

Merged
merged 1 commit into from Jun 17, 2019

Conversation

@praseodym
Copy link
Contributor

commented Jun 14, 2019

GitHub has a security policy page that uses a SECURITY.md file from the repository to show the project's security policy.

/kind documentation

Fixes #79049

NONE
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Hi @praseodym. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@praseodym

This comment has been minimized.

Copy link
Contributor Author

commented Jun 14, 2019

/assign @lavalamp

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

Looks like SECURITY.md can be added in .github as well: https://help.github.com/en/articles/adding-a-security-policy-to-your-repository

Wdyt about moving it there to avoid populating the root of the repo? I think the main benefit of having this doc is that people can see it while creating new issues and if they click on the Security tab, not as much as checking out the file from the root of the repo.

Umm, not sure which SIG but gonna go with contribex because the "security policy" is visible while creating new issues:
/sig contributor-experience
/priority important-longterm
/cc @cblecker @liggitt

Create SECURITY.md for GitHub security policy page
GitHub has a security policy page (https://github.com/kubernetes/kubernetes/security/policy)
that uses a SECURITY.md file from the repository to show the project's
security policy.

https://help.github.com/en/articles/adding-a-security-policy-to-your-repository

@praseodym praseodym force-pushed the praseodym:patch-1 branch from dd8818f to a3079f1 Jun 16, 2019

@praseodym

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

Looks like SECURITY.md can be added in .github as well: https://help.github.com/en/articles/adding-a-security-policy-to-your-repository

Wdyt about moving it there to avoid populating the root of the repo? I think the main benefit of having this doc is that people can see it while creating new issues and if they click on the Security tab, not as much as checking out the file from the root of the repo.

Didn't know that, I completely agree with not polluting the root of the repo. Changed to the commit to add it as .github/SECURITY.md instead.

Thanks!

@nikhita
Copy link
Member

left a comment

/ok-to-test
/lgtm

Leaving approval to @cblecker

/assign @cblecker
/unassign @lavalamp

@nikhita

This comment has been minimized.

Copy link
Member

commented Jun 16, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Jun 17, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, praseodym

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1894889 into kubernetes:master Jun 17, 2019

23 checks passed

cla/linuxfoundation praseodym authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@praseodym praseodym deleted the praseodym:patch-1 branch Jun 18, 2019

tedyu added a commit to tedyu/kubernetes that referenced this pull request Jun 18, 2019

Merge pull request kubernetes#79050 from praseodym/patch-1
Create SECURITY.md for GitHub security policy page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.