Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore cgroup pid support if related feature gates are disabled #79073

Merged
merged 1 commit into from Jun 22, 2019

Conversation

@rafatio
Copy link
Contributor

commented Jun 15, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
kubelet doesn't error when host OS doesn't have the pid cgroup mounted and related feature gates are disabled

Which issue(s) this PR fixes:
Fixes #79046

Does this PR introduce a user-facing change?:

Remove pids cgroup controller requirement when related feature gates are disabled

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Welcome @rafatio!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 15, 2019

Hi @rafatio. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

left a comment

/ok-to-test

Could you please sign the CLA? Let me know if there's anything I can do to help with that :)

Also, the issue this is described as fixing is already closed - was the existing fix incomplete? Alternatively, perhaps you could file a new issue for this specific problem and then this pr could link to that new issue?

Feel free to ping me after the test suite runs and I will mark w/ lgtm.

@rafatio

This comment has been minimized.

Copy link
Contributor Author

commented Jun 16, 2019

@mattjmcnaughton It was the wrong issue, the correct issue is #79046 (also edited on the comment)

Copy link
Contributor

left a comment

/lgtm

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

/assign @yujuhong

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 17, 2019

/test pull-kubernetes-bazel-build

@dashpole

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

/priority important-soon
This should be cherrypicked to the last two releases.
/lgtm

@RobertKrawitz

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

This looks fine as long as proper function of these feature gates is verified on kernels that do support the pids cgroup.

@yujuhong

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafatio, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit caf6b67 into kubernetes:master Jun 22, 2019
23 checks passed
23 checks passed
cla/linuxfoundation rafatio authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

Thanks again for this pr @rafatio :)

Do you want to create the cherry picks (see docs here: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-release/cherry-picks.md)? If you don't have time to, I'm happy to as well :)

k8s-ci-robot added a commit that referenced this pull request Jun 28, 2019
…3-upstream-release-1.15

Automated cherry pick of #79073: Ignore cgroup pid support if related feature gates are
k8s-ci-robot added a commit that referenced this pull request Jun 29, 2019
…3-upstream-release-1.14

Automated cherry pick of #79073: Ignore cgroup pid support if related feature gates are
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.