Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flag concurrent-statefulset-syncs to kube-controller-manager #79169

Merged
merged 9 commits into from Aug 1, 2019

Conversation

@YueHonghui
Copy link
Contributor

commented Jun 19, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:
While many other controllers like deployment has flag concurrent-xxx-syncs to set number of workers, the statefulset controller doesn't and just hard coded with 1 worker. It is very slow to deal with large number of statefulsets in cluster. This PR just export a flag concurrent-statefulset-syncs with default value to 1 for statefulset.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

`kube-controller-manager` now defaults to processing up to 5 statefulset objects concurrently to improve responsiveness, and exposes a `--concurrent-statefulset-syncs` flag to allow tuning the number of statefulset workers.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Welcome @YueHonghui!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

Hi @YueHonghui. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 19, 2019

finished CLA

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 19, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

/label api-review

@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jun 20, 2019

/kind feature

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2019

/assign @cheftako

return nil
}

errs := []error{}

This comment has been minimized.

Copy link
@justinsb

justinsb Jun 20, 2019

Member

Somewhere we should check that ConcurrentStatefulSetSyncs > 0 or >= 0 (not sure which), but I'm guessing this Validate is really just for flags and I'd expect to see it on StatefulSetControllerConfiguration

This comment has been minimized.

Copy link
@YueHonghui

YueHonghui Jun 21, 2019

Author Contributor

@justinsb Thank you for your suggestion, I have updated codes here to check that ConcurrentStatefulSetSyncs > 0.

@YueHonghui YueHonghui force-pushed the YueHonghui:add-statefulset-syncs branch from 404d279 to d33aa98 Jun 21, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

/approve

1. fix doc comment of statefulset config types.go
2. add missing deps k8s.io/kubernetes/pkg/controller/statefulset/config
@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

test failures are legitimate. look at the test failures to see what needs to be corrected

YueHonghui added some commits Jul 28, 2019

@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jul 30, 2019

@liggitt all checks done

@@ -71,6 +72,7 @@ func TestAddFlags(t *testing.T) {
"--cluster-signing-cert-file=/cluster-signing-cert",
"--cluster-signing-key-file=/cluster-signing-key",
"--concurrent-deployment-syncs=10",
"--concurrent-statefulset-syncs=5",

This comment has been minimized.

Copy link
@liggitt

liggitt Jul 30, 2019

Member

this should be set to a non-default value to make sure the flag actually modifies the config field correctly

@@ -0,0 +1,63 @@
/*
Copyright 2018 The Kubernetes Authors.

This comment has been minimized.

Copy link
@liggitt
@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/retest

1 similar comment
@YueHonghui

This comment has been minimized.

Copy link
Contributor Author

commented Jul 31, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 31, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, YueHonghui

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 31, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit d29f194 into kubernetes:master Aug 1, 2019

23 checks passed

cla/linuxfoundation YueHonghui authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.