Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace mapfile with kube::util::read-array #79186

Merged
merged 1 commit into from Jun 20, 2019

Conversation

@oomichi
Copy link
Member

commented Jun 19, 2019

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

During the review of #78779
we've known mapfile doesn't work on macOS.
So we need to use alternative way instead and this is it.

Does this PR introduce a user-facing change?:

NONE
@oomichi

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

/hold

@odinuge
Copy link
Member

left a comment

LGTM 😄

@BenTheElder
Copy link
Member

left a comment

/lgtm

@@ -349,23 +349,23 @@ cleanup()
# fi

# Check if the API server is still running
[[ -n "${APISERVER_PID-}" ]] && mapfile -t APISERVER_PIDS < <(pgrep -P "${APISERVER_PID}" ; ps -o pid= -p "${APISERVER_PID}")
[[ -n "${APISERVER_PID-}" ]] && kube::util::read-array APISERVER_PIDS < <(pgrep -P "${APISERVER_PID}" ; ps -o pid= -p "${APISERVER_PID}")

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jun 19, 2019

Member

This should just work but FYI @dims 😅

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 19, 2019

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 19, 2019

/approve

@oomichi oomichi force-pushed the oomichi:remove-mapfile branch from 10c0975 to 41b8fe9 Jun 19, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 19, 2019

@oomichi

This comment has been minimized.

Copy link
Member Author

commented Jun 19, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Jun 19, 2019

@BenTheElder
Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, oomichi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Replace mapfile with kube::util::read-array
During the review of #78779
we've known mapfile doesn't work on macOS.
So we need to use alternative way instead and this is it.

@oomichi oomichi force-pushed the oomichi:remove-mapfile branch from 41b8fe9 to 5628b6b Jun 20, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 20, 2019

@BenTheElder
Copy link
Member

left a comment

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 20, 2019

@oomichi

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 20, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 20, 2019

/sig testing
/priority important-soon

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 20, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 0ce16a3 into kubernetes:master Jun 20, 2019

23 checks passed

cla/linuxfoundation oomichi authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@odinuge odinuge referenced this pull request Jul 1, 2019

Closed

REQUEST: New membership for odinuge #975

6 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.