Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Kubelet enabling to support pod-overhead #79247
Pod and burstable QoS cgroups should take overhead of running a sandbox
While enabling PodOverhead support, refactored a couple of functions to remove duplicated logic and improve test coverage (ie, have eviction handling use the resources package).
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
The changes are pretty basic, but I was having issues getting a basic unit test working for
I think this is why the Deep.Equal is failing. Is this the expected behavior? Or, any suggestions?
@dashpole - yes, but that'll require looping through each resource in the list, verifying each entry exists, and that for each quantity, quantity.Equal(expected). A bit painful; I'd at least like to understand if its expected behavior or not. Perhaps there should be a "ResourceList" Equal function?
2 times, most recently
Aug 2, 2019
@egernst: GitHub didn't allow me to request PR reviews from the following users: mcastelino, jcvenegas.
Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.
changed the title
pod-overhead: utilize pod overhead for cgroup sizing in kubelet
Aug 2, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Hmm, the test failures are somewhat suspicious since it's the density & loader tests failing, which would be affected by PodOverhead. Except that overhead on those should be zero, and I think the feature gate is disabled, so probably a flake. Worth taking a look at though.
Thanks. It is at the very least a reminder of e2e tests which should be added for PodOverhead.