Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup PodPriority features gate #79262

Merged

Conversation

@draveness
Copy link
Member

commented Jun 21, 2019

/kind cleanup

What this PR does / why we need it:

PodPriority has already graduated to GA, and we could clean up the PodPriority gate which always true.

Which issue(s) this PR fixes:

Fixes #77152

Special notes for your reviewer:

I'm not sure about the release note, feel free to leave comments on that.

Does this PR introduce a user-facing change?:

The GA PodPriority feature gate is now on by default and cannot be disabled. The feature gate will be removed in v1.18.
@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/assign @Huang-Wei @bsalamat
/sig scheduling

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/priority backlog

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/kind cleanup

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/assign @liggitt

@draveness draveness force-pushed the draveness:feature/graduate-pod-priority-to-ga branch from 6af5043 to 2780858 Jun 21, 2019
Copy link
Contributor

left a comment

/lgtm

I'm not 100% up to date on the process for cleaning up a feature flag, but on the surface, this makes sense to me. All the code changes look safe.

Thanks for this cleanup.

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 21, 2019
@@ -509,7 +509,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS
Sysctls: {Default: true, PreRelease: featuregate.Beta},
DebugContainers: {Default: false, PreRelease: featuregate.Alpha},
PodShareProcessNamespace: {Default: true, PreRelease: featuregate.Beta},
PodPriority: {Default: true, PreRelease: featuregate.GA},
PodPriority: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},

This comment has been minimized.

Copy link
@liggitt

liggitt Jun 22, 2019

Member

add a comment indicating what release to remove this (v1.18)

@@ -719,8 +691,6 @@ func TestOrderedbyDiskDisableLocalStorage(t *testing.T) {
}

func TestOrderedbyInodes(t *testing.T) {
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.PodPriority, true)()
defer featuregatetesting.SetFeatureGateDuringTest(t, utilfeature.DefaultFeatureGate, features.LocalStorageCapacityIsolation, true)()

This comment has been minimized.

Copy link
@liggitt

liggitt Jun 22, 2019

Member

was removing LocalStorageCapacityIsolation accidental?

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 22, 2019

/approve

two nits, lgtm otherwise

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 22, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 23, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@draveness draveness force-pushed the draveness:feature/graduate-pod-priority-to-ga branch from 2780858 to ca6003b Jun 23, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jun 23, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

New changes are detected. LGTM label has been removed.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

/approve

two nits, lgtm otherwise

Comments have been addressed, please take another look, thanks @liggitt

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

/lgtm

@liggitt liggitt closed this Jun 23, 2019
@liggitt liggitt reopened this Jun 23, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

/lgtm

It didn't work 🤣

@liggitt liggitt added the lgtm label Jun 23, 2019
@k8s-ci-robot k8s-ci-robot merged commit 8ce45b6 into kubernetes:master Jun 23, 2019
23 checks passed
23 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@draveness draveness deleted the draveness:feature/graduate-pod-priority-to-ga branch Jul 1, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.