Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove several types in runtime serializer #79263

Merged

Conversation

@draveness
Copy link
Member

commented Jun 21, 2019

/kind cleanup
/priority backlog
/milestone 1.16

What this PR does / why we need it:

Remove several types in runtime serializer

Remove DirectCodecFactory(replace with serializer.WithoutConversionCodecFactory), DirectEncoder(replace with runtime.WithVersionEncoder) and DirectDecoder(replace with runtime.WithoutVersionDecoder). action required
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 21, 2019

@draveness: You must be a member of the kubernetes/milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your and have them propose you as an additional delegate for this responsibility.

In response to this:

/kind cleanup
/priority backlog
/milestone 1.16

What this PR does / why we need it:

Remove several types in runtime serializer

NONE

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/assign @deads2k

Copy link
Member

left a comment

scanned github, hitting no surprise

/lgtm

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 21, 2019

/retest

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/assign @jennybuckley

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Kindly ping @jennybuckley @deads2k for approvals, thanks

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 14, 2019

Hi @jennybuckley @deads2k, do you got the time to take a look at this? It's an easy one, thanks!

@jennybuckley

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

This seems safe, and if anyone was using these, the fix would be very simple to maintain compatibility

@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 6, 2019

This seems safe, and if anyone was using these, the fix would be very simple to maintain compatibility

Thank you, I updated the release note since this could need some users to maintain compatibility

@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 12, 2019

Friendly ping @liggitt for approval

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

clarify in the release note what should be used instead (the types these point to)

@liggitt

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

clarify in the release note what should be used instead (the types these point to)

done

@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c2286aa into kubernetes:master Aug 13, 2019
18 of 23 checks passed
18 of 23 checks passed
pull-kubernetes-bazel-build Job triggered.
Details
pull-kubernetes-bazel-test Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
tide Not mergeable. Job pull-kubernetes-bazel-build has not succeeded.
Details
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 13, 2019
@draveness draveness deleted the draveness:feature/remove-types-in-serializer branch Aug 13, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 13, 2019

@draveness: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-gce 7a83d78 link /test pull-kubernetes-e2e-gce

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.