Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm: add --control-plane-endpoint flag #79270

Merged
merged 1 commit into from Jul 3, 2019

Conversation

@SataQiu
Copy link
Member

commented Jun 21, 2019

What type of PR is this?
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#1625

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

kubeadm: provide "--control-plane-endpoint" flag for `controlPlaneEndpoint`
@rosti

rosti approved these changes Jun 21, 2019

Copy link
Member

left a comment

Thanks @SataQiu !
This is a good flag to have, however we also need to inherit it in the init phases, where appropriate.
A hint to start with are the phases, that inherit the APIServerAdvertiseAddress option, but others might need it as well.

/approve
/hold

@neolit123
Copy link
Member

left a comment

/hold
adding comments to kubernetes/kubeadm#1625

@neolit123

This comment has been minimized.

Copy link
Member

commented Jun 21, 2019

adding comments to kubernetes/kubeadm#1625

didn't see @rosti commented already here on the PR.

@neolit123

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

SGTM, let's have approval from @fabriziopandini when he is back.
/assign @fabriziopandini

@luxas

luxas approved these changes Jun 24, 2019

Copy link
Member

left a comment

Thank you very much for this @SataQiu!
Please fix @rosti's comment and then we're good to go

@luxas

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Jun 24, 2019

@luxas

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/priority important-soon

@SataQiu SataQiu force-pushed the SataQiu:fix-kubeadm-2019062102 branch from 750a804 to 33b9802 Jun 25, 2019

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jun 25, 2019

@SataQiu

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

I'm not sure if this covers all the InheritFlags, is there a good way to look it up? @rosti

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

/assign @rosti
PTAL

@fabriziopandini
Copy link
Member

left a comment

@SataQiu thanks for this PR!

I'm not sure if this covers all the InheritFlags, is there a good way to look it up

AFAIK, you can assume that the control plane endpoint flag should exist where the advertise address flag already exists (and from a quick check, you are already ok)

SGTM, let's have approval from @fabriziopandini when he is back.

In this case I agree with @luxas and @rosti; hopefully, we can manage to get this backported into the .1

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 3, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 3, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, rosti, SataQiu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rosti

This comment has been minimized.

Copy link
Member

commented Jul 3, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot merged commit 4c9fab5 into kubernetes:master Jul 3, 2019

23 checks passed

cla/linuxfoundation SataQiu authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.