Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove several GA features flag #79307

Merged

Conversation

@draveness
Copy link
Member

commented Jun 23, 2019

/kind cleanup

What this PR does / why we need it:

Remove several GA features flag:

Partial fix #79308

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove HugePages, VolumeScheduling, CustomPodDNS and PodReadinessGates feature flags
@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

/sig release // not sure, feel free to remove this
/priority important-soon

/assign @liggitt @childsb

@draveness draveness force-pushed the draveness:feature/cleanup-kube-features branch from 95042cb to 5f843da Jun 23, 2019
@k8s-ci-robot k8s-ci-robot added size/S and removed size/M labels Jun 23, 2019
@draveness draveness referenced this pull request Jun 23, 2019
6 of 6 tasks complete
@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 23, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 23, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46469ee into kubernetes:master Jun 23, 2019
23 checks passed
23 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@draveness draveness deleted the draveness:feature/cleanup-kube-features branch Jul 1, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
@themaizer

This comment has been minimized.

Copy link

commented Sep 3, 2019

@derekwaynecarr Is this indeed full removal of huge pages in 1.16?

@liggitt

This comment has been minimized.

Copy link
Member

commented Sep 3, 2019

@derekwaynecarr Is this indeed full removal of huge pages in 1.16?

No. Hugepages is GA and is enabled unconditionally. This PR removes the feature gate flag that allowed turning off the feature in previous releases.

akraino-github pushed a commit to akraino-edge-stack/ta-caas-kubernetes that referenced this pull request Oct 2, 2019
The flag no longer needed to be set.
kubernetes/kubernetes#79307

Change-Id: Ie49d8e21f22d9a759aa3925de9279cb0d4fdd2aa
Signed-off-by: Balazs Szekeres <balazs.szekeres@nokia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.