Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup feature gates for CSIPersistentVolume #79309

Conversation

@draveness
Copy link
Member

commented Jun 23, 2019

/kind cleanup

What this PR does / why we need it:

CSIPersistentVolume has already graduated to GA two releases ago, we could remove it in release 1.16

Which issue(s) this PR fixes:

Fix: #79308

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove CSIPersistentVolume feature gates
@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

/priority important-soon
/sig storage

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 23, 2019

@draveness draveness force-pushed the draveness:feature/cleanup-CSIPersistentVolume-feature-gates branch from d56a7ec to fc63859 Jun 23, 2019

@k8s-ci-robot k8s-ci-robot added size/L and removed size/M labels Jun 23, 2019

@draveness draveness marked this pull request as ready for review Jun 23, 2019

@mattjmcnaughton
Copy link
Contributor

left a comment

/lgtm

Modulo the Bazel changes. Ensure if those are flake or if we need to run an update script.

/test pull-kubernetes-bazel-test

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

the RBAC test fixture data needs to be regenerated, see the unit test failure output for instructions on how to do that

@draveness draveness force-pushed the draveness:feature/cleanup-CSIPersistentVolume-feature-gates branch from fc63859 to ad392e3 Jun 24, 2019

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

the RBAC test fixture data needs to be regenerated, see the unit test failure output for instructions on how to do that

Thanks Jordan, the comments have been addressed, please take another look.

@draveness draveness force-pushed the draveness:feature/cleanup-CSIPersistentVolume-feature-gates branch from ad392e3 to b470b08 Jun 25, 2019

@draveness draveness force-pushed the draveness:feature/cleanup-CSIPersistentVolume-feature-gates branch from b470b08 to 8e9472b Jun 25, 2019

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

/retest

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 25, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ad09532 into kubernetes:master Jun 25, 2019

23 checks passed

cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@draveness draveness deleted the draveness:feature/cleanup-CSIPersistentVolume-feature-gates branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.