Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use correct function to remove etcd member #79326

Merged
merged 1 commit into from Jun 24, 2019

Conversation

@bradbeam
Copy link
Contributor

commented Jun 24, 2019

Signed-off-by: Brad Beam brad.beam@talos-systems.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

This uses the correct function name for removing the etcd member from the cluster during a kubeadm reset.

Which issue(s) this PR fixes:

Fixes #79324

Does this PR introduce a user-facing change?:

Fix remove the etcd member from the cluster during a kubeadm reset.
fix: Use correct function to remove etcd member
Signed-off-by: Brad Beam <brad.beam@talos-systems.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

Welcome @bradbeam!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

Hi @bradbeam. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@draveness
Copy link
Member

left a comment

/ok-to-test
/priority critical-urgent

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Please specify a release note in the description

@draveness
Copy link
Member

left a comment

/lgtm

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@SataQiu

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/lgtm

@SataQiu

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@k8s-ci-robot k8s-ci-robot requested a review from neolit123 Jun 24, 2019

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/retest

@rosti

rosti approved these changes Jun 24, 2019

Copy link
Member

left a comment

Thanks @bradbeam !
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bradbeam, rosti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@draveness

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

Do we need to create a patch release 1.15.1 with this fix?

@rosti

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@draveness Yes, we can cherry pick it in 1.15.

@k8s-ci-robot k8s-ci-robot merged commit 80a3177 into kubernetes:master Jun 24, 2019

23 checks passed

cla/linuxfoundation bradbeam authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Jun 24, 2019

Merge pull request #79331 from draveness/automated-cherry-pick-of-#79…
…326-upstream-release-1.15

Automated cherry pick of #79326: fix: Use correct function to remove etcd member
@heckad

This comment has been minimized.

Copy link

commented Jul 16, 2019

When 1.15.1 will be released?

@bradbeam bradbeam deleted the bradbeam:etcdleave branch Jul 16, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

When 1.15.1 will be released?

probably in the next couple of weeks.
the release team does not know yet.

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

the release team does not know yet.

scratch that, it's 2019-07-18
https://github.com/kubernetes/sig-release/pull/686/files#diff-3b6790bdeadbf26945fec2a2336dbd2aR50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.