Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meta Table tests, fix --watch-only with single item #79345

Merged
merged 4 commits into from Jun 28, 2019

Conversation

@liggitt
Copy link
Member

commented Jun 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fixes kubectl get --watch-only with table output when watching a single item. Column headers are only included in the first watch event, which we suppressed printing. That meant no columns were defined for subsequent events.

Does this PR introduce a user-facing change?:

Fixes output of `kubectl get --watch-only` when watching a single resource

/sig cli
/cc @smarterclayton

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

/assign @seans3

@liggitt

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

/assign @soltysh

@seans3

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 28, 2019
@k8s-ci-robot k8s-ci-robot merged commit 4745946 into kubernetes:master Jun 28, 2019
23 checks passed
23 checks passed
cla/linuxfoundation liggitt authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@liggitt liggitt deleted the liggitt:kubectl-printing branch Jun 28, 2019
@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

/approve

retroactively

and also lgtm

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.