Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printer: fix a nil pointer dereference #79349

Merged
merged 1 commit into from Jun 25, 2019

Conversation

@roycaihw
Copy link
Member

commented Jun 24, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Fix a nil pointer dereference that could cause kube-apiserver to panic.

Does this PR introduce a user-facing change?:

Fix a bug in server printer that could cause kube-apiserver to panic.

/sig cli

@roycaihw

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@janetkuo

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

/lgtm

@janetkuo

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

This needs to be cherrypicked.

@roycaihw

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

This needs to be cherrypicked.

Sounds good. This was from 17740a2#diff-749b0f5911ddd5261b4ed5c2945d7c16R1585, which was added in 1.12. I assume 1.12 has retired so let's cherrypick it to 1.13, 1.14 and 1.15?

@roycaihw

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

/retest

@janetkuo

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

let's cherrypick it to 1.13, 1.14 and 1.15

SGTM

@roycaihw

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

I assume 1.12 has retired so let's cherrypick it to 1.13, 1.14 and 1.15?

Actually v1.12.10 cut (the last patch release) is planned Monday, July 1st. I can prepare a cherrypick for 1.12 as well

@janetkuo Could you add the approval label? Thanks

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 25, 2019

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

/approve
/lgtm

as well

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c1fc717 into kubernetes:master Jun 25, 2019

23 checks passed

cla/linuxfoundation roycaihw authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.