Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RateLimiter context aware and fix request may hang issue #79375

Merged

Conversation

@answer1991
Copy link
Contributor

commented Jun 25, 2019

What type of PR is this?

/kind bug
/kind feature

What this PR does / why we need it:

  1. RateLimiter add a context-aware method which is really necessary in async scene
  2. fix client-go request goruntine backlog in async scene

Which issue(s) this PR fixes:

Fixes #78766

Special notes for your reviewer:

The new method added in RateLimiter called Wait, it's context-aware, which is recommended to replace method Accept if the caller has context.

Does this PR introduce a user-facing change?:

Interface RateLimiter in client-go/util/flowcontrol package add a context-aware method called Wait.

RateLimiter add a context-aware method, fix client-go request goruntine backlog in async timeout scene.
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 25, 2019

Hi @answer1991. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

left a comment

/ok-to-test
/priority backlog

@answer1991 answer1991 force-pushed the answer1991:feature/flow-control-context-aware branch from 33ec23d to ce8805f Jun 25, 2019
@answer1991

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

/reset

@zhangxiaoyu-zidif

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

/retest

@fedebongio

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

/assign @aaron-prindle

@yliaog

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog Jun 27, 2019
@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 27, 2019

based on POC in liggitt@08dbd4e

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: answer1991, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 46667d0 into kubernetes:master Jun 28, 2019
23 checks passed
23 checks passed
cla/linuxfoundation answer1991 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@@ -141,3 +153,7 @@ func (t *fakeNeverRateLimiter) Accept() {
func (t *fakeNeverRateLimiter) QPS() float32 {
return 1
}

func (t *fakeNeverRateLimiter) Wait(ctx context.Context) error {
return errors.New("can not be accept")

This comment has been minimized.

Copy link
@tedyu

tedyu Jun 28, 2019

Contributor

can not be accept -> cannot be accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.