Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conformance walker should handle nested/adjacent Describes #79405

Merged

Conversation

@spiffxp
Copy link
Member

commented Jun 26, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Modifies the conformance test walker to keep track of more than the most
recent Describe token it bumped into. This ensures the full test name
can be displayed in the docs generated by this tool, and compared
against ineligible tags for promotion.

This also revealed that the regex for Context was too generous and would
catch things like SecurityContext or ContextWithFoo(...) calls

This would have prevented #79087 from passing its tests and attempting
to promote a [Disruptive] test to Conformance

Which issue(s) this PR fixes:
Fixes #79344

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE
Conformance walker should handle nested/adjacent Describes
This also revealed that the regex for Context was too generous and would
catch things like SecurityContext or ContextWithFoo(...) calls

This ensures that test suites with a ineligible tag in their top-level
Describe will be rejected from promotion to conformance
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from cheftako and mml Jun 26, 2019

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

/priority important-soon
/milestone v1.16

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

/test pull-kubernetes-e2e-gce-device-plugin-gpu

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

/retest

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

The pull-kuberentes-conformnce-image-test failure is unrelated and non-blocking

W0626 16:46:44.211] ++ kind create cluster --image=kindest/node:latest --retain --wait=1m --loglevel=debug --config=/workspace/_artifacts/kind-config.yaml
W0626 16:46:44.388] Error: error loading config: decoding failure: no kind "Config" is registered for version "kind.sigs.k8s.io/v1alpha2" in scheme "pkg/runtime/scheme.go:101"
W0626 16:46:44.391] + cleanup
W0626 16:46:44.391] + kind export logs /workspace/_artifacts/logs
W0626 16:46:44.692] Error: unknown cluster "kind"
W0626 16:46:44.695] + true
W0626 16:46:44.696] + [[ true = true ]]
W0626 16:46:44.696] + kind delete cluster
W0626 16:46:44.788] Error: unknown cluster "kind"

PTAL

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

The pull-kuberentes-conformnce-image-test failure is unrelated and non-blocking

that script is awful (and not mine!) :( ... will look into it in test-infra
/test pull-kubernetes-e2e-kind

@spiffxp

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

/test pull-kubernetes-conformance-image-test

1 similar comment
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jun 26, 2019

/test pull-kubernetes-conformance-image-test

@johnSchnake

This comment has been minimized.

Copy link
Contributor

commented Jun 27, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jun 27, 2019

@k8s-ci-robot k8s-ci-robot merged commit d009936 into kubernetes:master Jun 27, 2019

24 checks passed

cla/linuxfoundation spiffxp authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Job succeeded.
Details
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-e2e-kind Job succeeded.
Details
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@spiffxp spiffxp deleted the spiffxp:fix-walker-to-walk-all-describes branch Jun 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.