Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update example/rethinkdb to v1beta3 #7946

Merged
merged 1 commit into from May 11, 2015

Conversation

Projects
None yet
5 participants
@caesarxuchao
Copy link
Member

commented May 8, 2015

update example/rethinkdb to v1beta3, add external load balancer to work on GCE, add a comment about nodeSelector in gen-pod.sh.
@nikhiljindal @antmanler

@googlebot googlebot added the cla: yes label May 8, 2015

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

commented May 8, 2015

@nikhiljindal The UI works. But I think I need to change the run.sh as well, as pointed out in #7258. Please hold until I fix it. Thanks.

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:rethinkdb-example branch 2 times, most recently from 0922c5f to a5e8e35 May 11, 2015

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

commented May 11, 2015

I fix the run.sh to v1beta3. @antmanler, could you rebuild your docker image? or you can copy mine at caesarxuchao/rethinkdb:v2. Thank you.

@nikhiljindal let's wait for greens


Note that you may need to create a firewall rule to allow the traffic, assuming you are using GCE:
```
$ gcloud compute firewall-rules create rehitnkdb --allow=tcp:8080

This comment has been minimized.

Copy link
@nikhiljindal

nikhiljindal May 11, 2015

Member

typo in rethinkdb

@@ -32,41 +32,42 @@ if [[ ${NAME} == "admin" ]]; then
fi

NODE=""
# One needs to label a node with the same key/value pair,
# i.e., 'kubectl lable nodes <node-name> name=${2}'

This comment has been minimized.

Copy link
@nikhiljindal

nikhiljindal May 11, 2015

Member

lable -> label

@@ -10,6 +10,12 @@ Setting up a [rethinkdb](http://rethinkdb.com/) cluster on [kubernetes](http://k

Quick start
-----------
**Step 0**

This comment has been minimized.

Copy link
@nikhiljindal

nikhiljindal May 11, 2015

Member

Why is this required?

This comment has been minimized.

Copy link
@caesarxuchao

caesarxuchao May 11, 2015

Author Member

The author of this example defined everything under rethinkdb namespace in the yaml files..

@nikhiljindal

This comment has been minimized.

Copy link
Member

commented May 11, 2015

Will wait for @antmanler's LGTM before merging.

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:rethinkdb-example branch from a5e8e35 to fcba328 May 11, 2015

@caesarxuchao

This comment has been minimized.

Copy link
Member Author

commented May 11, 2015

@nikhiljindal. Thank you for the picks. I was too hurry to go home : )

@antmanler

This comment has been minimized.

Copy link
Contributor

commented May 11, 2015

@caesarxuchao Thank you for you contribution, I'm so busy these days, and sorry for late reply.

I've copied and pushed your image to antmanler/rethinkdb, and it works well on my local cluster.

LGTM.


change the namespace of the current context to "rethinkdb"
```
$kubectl config view | grep "current-context" | awk '{print $2}' | xargs -I {} kubectl config set-context {} --namespace=rethinkdb

This comment has been minimized.

Copy link
@nikhiljindal

nikhiljindal May 11, 2015

Member

We use
config view -o template --template='{{index . "current-context"}}' at other places like https://github.com/GoogleCloudPlatform/kubernetes/blob/master/cluster/kubectl.sh#L127 which seems cleaner.

This comment has been minimized.

Copy link
@caesarxuchao

caesarxuchao May 11, 2015

Author Member

Updated.

update example/rethinkdb to v1beta3
add external load balancer to work on GCE

add a comment about nodeSelector in gen-pod.sh

update the image/run.sh to v1beta3

@caesarxuchao caesarxuchao force-pushed the caesarxuchao:rethinkdb-example branch from fcba328 to 25cca64 May 11, 2015

@nikhiljindal

This comment has been minimized.

Copy link
Member

commented May 11, 2015

LGTM, thanks.
Shippable is green, merging.

nikhiljindal added a commit that referenced this pull request May 11, 2015

Merge pull request #7946 from caesarxuchao/rethinkdb-example
update example/rethinkdb to v1beta3

@nikhiljindal nikhiljindal merged commit 14055d6 into kubernetes:master May 11, 2015

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.