Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completely remove initializers from k/k #79504

Merged
merged 2 commits into from Jun 28, 2019

Conversation

@yue9944882
Copy link
Member

commented Jun 28, 2019

The alpha `metadata.initializers` field, deprecated in 1.13, has been removed.
@yue9944882

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

/sig api-machinery
/kind cleanup

we should have done it in 1.15
/cc @deads2k @liggitt

@k8s-ci-robot k8s-ci-robot requested review from deads2k and liggitt Jun 28, 2019

@k8s-ci-robot k8s-ci-robot requested review from caesarxuchao and enisoc Jun 28, 2019

@yue9944882 yue9944882 force-pushed the yue9944882:chore/remove-initializer branch 3 times, most recently from 69ab7fc to 991b5da Jun 28, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Jun 28, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

yue9944882 added some commits Jun 28, 2019

@yue9944882 yue9944882 force-pushed the yue9944882:chore/remove-initializer branch from 991b5da to 95ed426 Jun 28, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Jun 28, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot merged commit 665e76d into kubernetes:master Jun 28, 2019

23 checks passed

cla/linuxfoundation yue9944882 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.