Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default resourceGroup should be used when value of annotation azure-load-balancer-resource-group is empty string #79514

Merged
merged 1 commit into from Jun 28, 2019

Conversation

@feiskyer
Copy link
Member

commented Jun 28, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it: Default resourceGroup should be used when value of annotation azure-load-balancer-resource-group is empty string.

Which issue(s) this PR fixes:

Fixes #79513

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Default resourceGroup should be used when the value of annotation azure-load-balancer-resource-group is an empty string.

/sig azure
/kind bug
/priority critical-urgent

Default resourceGroup should be used when value of annotation azure-l…
…oad-balancer-resource-group is empty string
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

/assign @andyzhangx

@feiskyer feiskyer added this to In progress in SIG Azure via automation Jun 28, 2019

@andyzhangx
Copy link
Member

left a comment

/lgtm

@feiskyer

This comment has been minimized.

Copy link
Member Author

commented Jun 28, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 5019bb5 into kubernetes:master Jun 28, 2019

23 checks passed

cla/linuxfoundation feiskyer authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

SIG Azure automation moved this from In progress to Done Jun 28, 2019

@feiskyer feiskyer deleted the feiskyer:fix-lb-rg branch Jun 29, 2019

k8s-ci-robot added a commit that referenced this pull request Jun 29, 2019

Merge pull request #79518 from feiskyer/automated-cherry-pick-of-#795…
…14-upstream-release-1.13

Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation

k8s-ci-robot added a commit that referenced this pull request Jun 29, 2019

Merge pull request #79519 from feiskyer/automated-cherry-pick-of-#795…
…14-upstream-release-1.14

Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation

feiskyer added a commit that referenced this pull request Jun 30, 2019

Merge pull request #79517 from feiskyer/automated-cherry-pick-of-#795…
…14-upstream-release-1.12

Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation

k8s-ci-robot added a commit that referenced this pull request Jul 3, 2019

Merge pull request #79521 from feiskyer/automated-cherry-pick-of-#795…
…14-upstream-release-1.15

Automated cherry pick of #79514: Default resourceGroup should be used when value of annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.