Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure API updates #79583

Merged
merged 4 commits into from Jul 1, 2019

Conversation

@justaugustus
Copy link
Member

commented Jul 1, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind feature

What this PR does / why we need it:

  • Update azure-sdk-for-go/services/containerregistry to 2018-09-01
  • Update azure-sdk-for-go/services/network to 2018-08-01

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Update Azure API versions (containerregistry --> 2018-09-01, network --> 2018-08-01)
justaugustus added 4 commits Jul 1, 2019
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

/assign @feiskyer @andyzhangx @khenidak
/sig azure
/priority important-soon
/milestone v1.16

@feiskyer

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@feiskyer

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

The changes looks good, let's check what CI would report.

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

(Can't tell if this is a flake or not)
/test pull-kubernetes-e2e-aks-engine-azure

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Actually, this job seems to fail pretty consistently on that Up step: https://prow.k8s.io/job-history/kubernetes-jenkins/pr-logs/directory/pull-kubernetes-e2e-aks-engine-azure
We should look into it, but not block on it here.

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

Created #79597 to investigate the pull-kubernetes-e2e-aks-engine-azure failure.

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

For deps:
/assign @cblecker @dims @BenTheElder

@feiskyer

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

The failure is not related to this change, need to investigate why it's failing again.

Copy link
Member

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 1, 2019
Copy link
Member

left a comment

/approve
for vendor

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, feiskyer, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

/hold
do we care about the optional e2e failure?
unhold if not :-)

@justaugustus

This comment has been minimized.

Copy link
Member Author

commented Jul 1, 2019

@BenTheElder -- nope, but thanks for checking! I've opened #79597 to track that.
/hold cancel

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 1, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 1, 2019

clearing it to make the bots go away 🙃
/skip
[may need to be done again when the failure comes back in, but before the bot comments again..]

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@justaugustus: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure df3a7d4 link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 38e8b8a into kubernetes:master Jul 1, 2019
23 of 24 checks passed
23 of 24 checks passed
pull-kubernetes-e2e-aks-engine-azure Job failed.
Details
cla/linuxfoundation justaugustus authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 2, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.