Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
DO NOT publish openapi specs containing bad types #79587
for now, we can set arbitrary types for the json schema like:
validation: openAPIV3Schema: properties: spec: type: bug // whatever type except for the root element type: object
this is violating https://tools.ietf.org/html/draft-wright-json-schema-00#section-4.2 and this pull adds a list of supported types and their validation according to the specification.
Jul 1, 2019
this is a breaking change, so it cannot go in unconditionally.
what is the behavior:
we should ensure:
yea.. we have to ensure backward-compatibility in this fix. from a slack discuss w/ @sttts, we can only forbid invalid-typed CRD under following cases, so that existing CRD will keep working:
confirmed this one, kubectl aborts after requesting
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing