Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make kubectl --raw consistent for create, update, get, delete #79724

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@deads2k
Copy link
Contributor

commented Jul 3, 2019

We have kubectl create --raw and kubectl get --raw. This rounds out the featureset with kubectl replace --raw and kubectl delete --raw.

add  `kubectl replace --raw` and `kubectl delete --raw` to have parity with create and get

@kubernetes/sig-cli-maintainers
/kind cleanup
/priority important-longterm

@liggitt
Copy link
Member

left a comment

nits, lgtm

Show resolved Hide resolved pkg/kubectl/cmd/create/create.go Outdated
Show resolved Hide resolved pkg/kubectl/cmd/rawhttp/raw.go Outdated

@deads2k deads2k force-pushed the deads2k:update-raw branch from f53e06c to 0cdfe18 Jul 3, 2019

Show resolved Hide resolved pkg/kubectl/cmd/rawhttp/raw.go Outdated

@deads2k deads2k force-pushed the deads2k:update-raw branch 3 times, most recently from 9af919a to 39caad3 Jul 3, 2019

@dims

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

/uncc

@k8s-ci-robot k8s-ci-robot removed the request for review from dims Jul 8, 2019

@deads2k deads2k force-pushed the deads2k:update-raw branch from 39caad3 to d09f7a1 Jul 8, 2019

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

/approve
/lgtm

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 8, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

4 similar comments
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@deads2k deads2k force-pushed the deads2k:update-raw branch from d09f7a1 to 6606a16 Jul 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 9, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k deads2k force-pushed the deads2k:update-raw branch from 6606a16 to 09c55bd Jul 9, 2019

@deads2k deads2k added the lgtm label Jul 9, 2019

@deads2k

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

minor fix up for stock flags being added. retagging.

@k8s-ci-robot k8s-ci-robot merged commit b130ff4 into kubernetes:master Jul 9, 2019

23 checks passed

cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.