Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote WatchBookmarks to beta #79786

Merged
merged 3 commits into from Jul 12, 2019

Conversation

@wojtek-t
Copy link
Member

commented Jul 4, 2019

Ref kubernetes/enhancements#956

Promote WatchBookmark feature to beta and enable it by default.
With WatchBookmark feature, clients are able to request watch events with BOOKMARK type. Clients should not assume bookmarks are returned at any specific interval, nor may they assume the server will send any BOOKMARK event during a session.
@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

/retest

@wojtek-t wojtek-t force-pushed the wojtek-t:watch_bookmarks_beta branch from d0e3009 to d0e407a Jul 4, 2019

@wojtek-t wojtek-t changed the title [WIP] Promote WatchBookmarks to beta Promote WatchBookmarks to beta Jul 5, 2019

@wojtek-t wojtek-t assigned lavalamp and unassigned wojtek-t Jul 5, 2019

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 5, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@lavalamp

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/lgtm
/approve

(Since it appears we have met the beta criteria given in the KEP)

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lavalamp, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wojtek-t added some commits Jul 4, 2019

@wojtek-t wojtek-t force-pushed the wojtek-t:watch_bookmarks_beta branch from d0e407a to 72eadb1 Jul 12, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

New changes are detected. LGTM label has been removed.

@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

I only rebased the auto-generated filed. Reapply lgtm label.

@wojtek-t wojtek-t added the lgtm label Jul 12, 2019

@k8s-ci-robot k8s-ci-robot merged commit a46eed0 into kubernetes:master Jul 12, 2019

23 checks passed

cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@wojtek-t wojtek-t deleted the wojtek-t:watch_bookmarks_beta branch Jul 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.