Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix nil pointer dereference error in volume_stat_calculator #79851
volume_stat_calculator expects GetMetrics function to return MetricsError error
What type of PR is this?
What this PR does / why we need it:
kubelet panics inside volume_stat_calculator since the function expects GetMetrics function to return non nil value for metrics when err is nil. However, csi_metrics returns nil for both metrics, and error when the driver does not support metrics.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Hi @jparklab. Thanks for your PR.
I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with
Once the patch is verified, the new status will be reflected by the
I understand the commands that are listed here.
@jparklab If I remember the discussions we had while working on metrics PR, its perfectly fine to return
@gnufied can you review this PR and issue?
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing