Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code docs around old todo that is not going to happen #79892

Merged

Conversation

@mikebrow
Copy link
Member

commented Jul 8, 2019

Going through old TODOs to clean up kubelet. I see there was a todo to remove normalization of cached timestamps when issue #15262 and pr #15263 merged, but they were closed 4years ago. Time to remove the TODO and update the code documentation to reflect.

@Random-Liu

Signed-off-by: Mike Brown brownwm@us.ibm.com

/kind cleanup

na
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
Copy link
Contributor

left a comment

/lgtm

Thanks for this clean up :)

@mattjmcnaughton

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

/assign @tallclair
/test pull-kubernetes-e2e-gce-100-performance

@tallclair

This comment has been minimized.

Copy link
Member

commented Jul 10, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikebrow, tallclair

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 11, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b168ab1 into kubernetes:master Jul 11, 2019
23 checks passed
23 checks passed
cla/linuxfoundation mikebrow authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.