Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apiaggregation available controller should only hit required endpoint #79895

Merged
merged 1 commit into from Jul 9, 2019

Conversation

@deads2k
Copy link
Contributor

commented Jul 8, 2019

Fixes #79838

We should only check for endpoints that aggregation is required to serve. This updates the controller to hit /apis/group/version instead of /.

Resolves an issue serving aggregated APIs backed by services that respond to requests to `/` with non-2xx HTTP responses

@kubernetes/sig-api-machinery-bugs

@liggitt

@deads2k deads2k force-pushed the deads2k:aggregated-fix-endpont branch from 73ae94b to a84db7e Jul 8, 2019

@deads2k

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

Updated

@deads2k

This comment has been minimized.

Copy link
Contributor Author

commented Jul 8, 2019

/retest

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

/priority important-soon
/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

thanks, can you pick to 1.15 once this merges?

@k8s-ci-robot k8s-ci-robot merged commit 262e59b into kubernetes:master Jul 9, 2019

23 checks passed

cla/linuxfoundation deads2k authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

k8s-ci-robot added a commit that referenced this pull request Jul 9, 2019

Merge pull request #79918 from yue9944882/automated-cherry-pick-of-#7…
…9895-upstream-release-1.15

Automated cherry pick of #79895: apiaggregation available controller should only hit required

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.