Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.12.7 #79966

Merged
merged 1 commit into from Jul 12, 2019

Conversation

@tao12345666333
Copy link
Contributor

commented Jul 10, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler,
and the linker.
See the Go 1.12.7 milestone on our issue tracker for details.

golang/go@go1.12.6...go1.12.7

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

update to use go 1.12.7
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 10, 2019

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 10, 2019

/assign @fejta @luxas

PTAL 😸

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@tao12345666333 hi, you can mention this PR in #sig-testing and/or #sig-release on the k8s slack. normally they can decide if we should bump golang.

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@neolit123 Thanks for your reminder!

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

xref: #79912

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/assign
/ok-to-test

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

W0711 02:36:41.825] Step 1/16 : FROM k8s.gcr.io/kube-cross:v1.12.7-1
W0711 02:36:41.825] manifest for k8s.gcr.io/kube-cross:v1.12.7-1 not found

We need k8s.gcr.io/kube-cross:v1.12.7-1 image.

@javier-b-perez PTAL Thanks.

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/unassign fejta luxas
/assign @javier-b-perez

Bazel tests passing. We should be good to build/push the image.

@k8s-ci-robot k8s-ci-robot assigned javier-b-perez and unassigned fejta and luxas Jul 11, 2019

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

I've created the image [1] and started the process to have kube-cross:v1.12.7-1 in k8s.gcr.io
[1] gcr.io/k8s-staging-build-image/kube-cross:v1.12.7-1

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/test pull-kubernetes-cross
/test pull-kubernetes-verify

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Image should be available in k8s.gcr.io/kube-cross:v1.12.7-1

@javier-b-perez

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 11, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@tao12345666333 Can you also update the version here:

version: 1.12.6

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

sure

Update to go 1.12.7
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>

@tao12345666333 tao12345666333 force-pushed the tao12345666333:go-1.12.7 branch from 8113dd2 to dfa46f8 Jul 11, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 11, 2019

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 11, 2019

@cblecker Addressed. Thanks.

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 824dfe9 into kubernetes:master Jul 12, 2019

18 of 23 checks passed

pull-kubernetes-cross Job triggered.
Details
pull-kubernetes-e2e-gce Job triggered.
Details
pull-kubernetes-e2e-gce-100-performance Job triggered.
Details
pull-kubernetes-kubemark-e2e-gce-big Job triggered.
Details
pull-kubernetes-verify Job triggered.
Details
cla/linuxfoundation tao12345666333 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@tao12345666333 tao12345666333 deleted the tao12345666333:go-1.12.7 branch Jul 12, 2019

k8s-ci-robot added a commit that referenced this pull request Aug 16, 2019

Merge pull request #81521 from cblecker/automated-cherry-pick-of-#78958-
#79966-#81390-#81489-upstream-release-1.14

Update release-1.14 to go 1.12.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.