Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove make-symlinks flag and corresponding code #80017

Merged
merged 1 commit into from Jul 11, 2019

Conversation

@Pothulapati
Copy link
Contributor

commented Jul 11, 2019

Signed-off-by: Tarun Pothulapati tarunpothulapati@outlook.com

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
make-symlinks flag in HyperKube has been deprecated for a while, this PR removes the flag completely along with the corresponding code.

Which issue(s) this PR fixes:

Fixes #75491

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

hyperkube: the `--make-symlinks` flag, deprecated in v1.14, has been removed.

@dims

removed make-symlink flag and corresponding code in hyperkube
Signed-off-by: Tarun Pothulapati <tarunpothulapati@outlook.com>
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Welcome @Pothulapati!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Hi @Pothulapati. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nikhita

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/ok-to-test

@dims

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/assign @thockin @liggitt
/approve
/lgtm

Easy one :) no one uses it, deprecated a while ago and its time to remove it.

@dims

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/priority important-soon

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

Updated release note to include the specific release where the flag was deprecated

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, Pothulapati

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7e4a6ca into kubernetes:master Jul 11, 2019

23 checks passed

cla/linuxfoundation Pothulapati authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Job succeeded.
Details
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@Pothulapati Pothulapati deleted the Pothulapati:removesys branch Jul 17, 2019

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.