Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for etcd2 from cluster/images/etcd image #80037

Merged

Conversation

@dims
Copy link
Member

commented Jul 11, 2019

Removes etcd2 code and images.
Etcd2 is no longer supported as of 1.13, so rollback and management
tools for etcd2 should not be shipped any longer. If it is still desired
the older versions of the image can be used.

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #80036

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

etcd migration image no longer supports etcd2 version. 
@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/priority important-soon
/area code-organization

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

/approve

@jpbetz has lgtm

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

LGTM, but I will let @jpbetz to finally lgtm it.

@roycaihw

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

@roycaihw: GitHub didn't allow me to request PR reviews from the following users: jingyih.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @jingyih @wenjiaswe

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dims dims force-pushed the dims:remove-support-for-etcd2-from-images-etcd branch from b5fe807 to 318288d Jul 11, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jingyih

This comment has been minimized.

Copy link
Contributor

commented Jul 11, 2019

Do we still need the upgrade and downgrade tests that involve etcd2?

// upgrades
{"v2-v3-up", 1, "2.2.1/etcd2", "3.0.17/etcd3", "https"},

// downgrades
{"v3-v2-down", 1, "3.0.17/etcd3", "2.2.1/etcd2", "https"},

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/retest

dims added some commits Jul 11, 2019

Remove support for etcd2 from cluster/images/etcd image
Removes etcd2 code and images.
Etcd2 is no longer supported as of 1.13, so rollback and management
tools for etcd2 should not be shipped any longer. If it is still desired
the older versions of the image can be used.

Change-Id: I516c40067f0a57c42d2a6ab4612071c5e556a005

@dims dims force-pushed the dims:remove-support-for-etcd2-from-images-etcd branch from 318288d to 88b0be7 Jul 12, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

@jingyih fixed. PTAL

@jingyih

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

lgtm. Thanks!

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

@jpbetz @roycaihw can you please /lgtm based on the lgtm from @jingyih above?

@wojtek-t

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 12, 2019

@k8s-ci-robot k8s-ci-robot merged commit aaad86c into kubernetes:master Jul 12, 2019

23 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.