Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated --containerized flag in kubelet #80043

Conversation

@dims
Copy link
Member

commented Jul 11, 2019

This flag was deprecated in 1.14

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #74148

Special notes for your reviewer:
Flag was deprecated in #74267

Does this PR introduce a user-facing change?:

kubelet's --containerized flag was deprecated in 1.14. This flag is removed in 1.16.
@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

related to #74177

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/priority important-soon

@dims dims force-pushed the dims:remove-deprecated-containerized-flag-in-kubelet branch from 35b5422 to 84923c6 Jul 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

/assign @Random-Liu

@dims dims force-pushed the dims:remove-deprecated-containerized-flag-in-kubelet branch from 84923c6 to 463db59 Jul 11, 2019

Remove deprecated --containerized flag in kubelet
This flag was deprecated in 1.14

@dims dims force-pushed the dims:remove-deprecated-containerized-flag-in-kubelet branch from 463db59 to 3b2a61d Jul 11, 2019

@dims

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/retest

@derekwaynecarr

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

thanks for following up on this.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 12, 2019

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 12, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 676417e into kubernetes:master Jul 12, 2019

23 checks passed

cla/linuxfoundation dims authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@bgilbert bgilbert referenced this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.