Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proxy/ipvs: increase log level for graceful termination #80100

Merged
merged 1 commit into from Jul 13, 2019

Conversation

@andrewsykim
Copy link
Member

commented Jul 12, 2019

Signed-off-by: Andrew Sy Kim kiman@vmware.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
In #78395 we bumped the IPVS graceful termination log level from v=0 to v=2 since the graceful termination logs get pretty verbose. After some discussion in #71071, v=5 (or maybe even. v=6?) makes more sense.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Increase log level for graceful termination to v=5
@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/sig network
/assign @lbernail

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

/priority important-longterm

@dcbw

This comment has been minimized.

Copy link
Member

commented Jul 12, 2019

/lgtm

@lbernail

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, lbernail

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

proxy/ipvs: increase log level for graceful termination
Signed-off-by: Andrew Sy Kim <kiman@vmware.com>

@andrewsykim andrewsykim force-pushed the andrewsykim:ipvs-logging branch from 6800e19 to 7aa1700 Jul 12, 2019

@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 12, 2019

@andrewsykim

This comment has been minimized.

Copy link
Member Author

commented Jul 12, 2019

Can I get another lgtm, I ended up bumping the log level for the "Not deleting RS" log message as well

@lbernail

This comment has been minimized.

Copy link
Contributor

commented Jul 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 13, 2019

@k8s-ci-robot k8s-ci-robot merged commit 87b7447 into kubernetes:master Jul 13, 2019

23 checks passed

cla/linuxfoundation andrewsykim authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.