Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubeadm/*/phases/init/certs,kubeconfig: add "kubernetes-version" flag #80115

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@gyuho
Copy link
Member

commented Jul 12, 2019

If empty "--kubernetes-version" is given (as it's not configurable now)
k8s.io/kubernetes/cmd/kubeadm/app/util/version.go.KubernetesReleaseVersion
will fetch the version from the internet.

But, this can fail:

% kubeadm init phase certs ca --cert-dir ...
unable to fetch file. URL: "https://dl.k8s.io/release/stable-1.txt", status: 502 Bad Gateway
failed to run commands: exit status 1

Can happen to other commands:

% kubeadm init phase kubeconfig controller-manager ...
% kubeadm init phase kubeconfig scheduler ...

This makes "--kubernetes-version" configurable, so users can enable offline mode.

Signed-off-by: Gyuho Lee leegyuho@amazon.com

What type of PR is this?
/kind feature

What this PR does / why we need it:

Add --kubernetes-version to kubeadm init phase certs ca and kubeadm init phase kubeconfig.

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer:

There's a way to specify the kubernetes-version by specifying --config flag, but it would be handy to have this

Does this PR introduce a user-facing change?:

Add --kubernetes-version to "kubeadm init phase certs ca" and "kubeadm init phase kubeconfig"
If empty "--kubernetes-version" is given (as it's not configurable now)
k8s.io/kubernetes/cmd/kubeadm/app/util/version.go.KubernetesReleaseVersion
will fetch the version from the internet.

But, this can fail:

% kubeadm init phase certs ca --cert-dir ...
unable to fetch file. URL: "https://dl.k8s.io/release/stable-1.txt", status: 502 Bad Gateway
failed to run commands: exit status 1

Can happen to other commands:

% kubeadm init phase kubeconfig controller-manager ...
% kubeadm init phase kubeconfig scheduler ...

This make "--kubernetes-version" configurable, so users can enable offline mode.

Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
@timothysc

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Copy link
Member

left a comment

thanks @gyuho
long term, we have plans to make the fetch version from the internet optional.

/lgtm
/approve
/priority backlog

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyuho, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ab8506f into kubernetes:master Jul 15, 2019
23 checks passed
23 checks passed
cla/linuxfoundation gyuho authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.