Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
kubeadm/*/phases/init/certs,kubeconfig: add "kubernetes-version" flag #80115
If empty "--kubernetes-version" is given (as it's not configurable now)
But, this can fail:
% kubeadm init phase certs ca --cert-dir ...
Can happen to other commands:
% kubeadm init phase kubeconfig controller-manager ...
This makes "--kubernetes-version" configurable, so users can enable offline mode.
Signed-off-by: Gyuho Lee email@example.com
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
There's a way to specify the
Does this PR introduce a user-facing change?:
If empty "--kubernetes-version" is given (as it's not configurable now) k8s.io/kubernetes/cmd/kubeadm/app/util/version.go.KubernetesReleaseVersion will fetch the version from the internet. But, this can fail: % kubeadm init phase certs ca --cert-dir ... unable to fetch file. URL: "https://dl.k8s.io/release/stable-1.txt", status: 502 Bad Gateway failed to run commands: exit status 1 Can happen to other commands: % kubeadm init phase kubeconfig controller-manager ... % kubeadm init phase kubeconfig scheduler ... This make "--kubernetes-version" configurable, so users can enable offline mode. Signed-off-by: Gyuho Lee <firstname.lastname@example.org>
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing