Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.15] Update to go 1.12.7 #80134

Merged

Conversation

@tao12345666333
Copy link
Contributor

commented Jul 14, 2019

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

go1.12.7 (released 2019/07/08) includes fixes to cgo, the compiler,
and the linker.
See the Go 1.12.7 milestone on our issue tracker for details.

golang/go@go1.12.6...go1.12.7

Special notes for your reviewer:

This is part or #79912

Does this PR introduce a user-facing change?:

update to use go 1.12.7
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

Hi @tao12345666333. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

Split commits so that we can cherry pick to release-1.14

@tao12345666333 tao12345666333 changed the title Update to go 1.12.7 [release-1.15] Update to go 1.12.7 Jul 14, 2019

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

commented here:
#79912 (comment)

@@ -15,7 +15,7 @@ rules:
branch: release-1.15
dir: staging/src/k8s.io/code-generator
name: release-1.15
go: 1.12.5
go: 1.12.7

This comment has been minimized.

Copy link
@cblecker

cblecker Jul 14, 2019

Member

are these changes needed @nikhita @sttts ? I don't think we've done these before when bumping go versions

This comment has been minimized.

Copy link
@nikhita

nikhita Jul 15, 2019

Member

Yes, these are needed if we are bumping the version in the release-1.15 branch.

I don't think we've done these before when bumping go versions

We should have done that. :) Created #80151 and kubernetes/publishing-bot#197.

It doesn't really matter because the go version here is mainly used while testing client-go and there haven't been any particular changes in client-go that are specifically related to features in new go versions, but it's definitely better to bump the version in case there are any bug fixes, etc. 👍

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

Thanks @nikhita !

/ok-to-test

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

/remove-area kubeadm

tao12345666333 added some commits Jul 15, 2019

Update to go 1.12.7
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Update publishing/rules to go 1.12.7
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>

@tao12345666333 tao12345666333 force-pushed the tao12345666333:update-go-for-1.15 branch from 9942fcf to c813094 Jul 15, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

/retest

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 18, 2019

/test pull-kubernetes-kubemark-e2e-gce-big

not sure if the test has been fixed.

@tao12345666333

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

@cblecker PTAL. 😸

@justaugustus justaugustus added this to In progress in Release Engineering Jul 25, 2019

@cblecker

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

/lgtm
/approve
/test all

@k8s-ci-robot k8s-ci-robot added the lgtm label Aug 7, 2019

@nikhita

nikhita approved these changes Aug 7, 2019

Copy link
Member

left a comment

/approve
/retest

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Aug 7, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, nikhita, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nikhita

This comment has been minimized.

Copy link
Member

commented Aug 7, 2019

/milestone v1.15

@k8s-ci-robot k8s-ci-robot added this to the v1.15 milestone Aug 7, 2019

@tpepper

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

I'm going to declare this is
/kind bug
because we are picking up key toolchain bugfixes.

@fejta-bot

This comment has been minimized.

Copy link

commented Aug 9, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 3f2d0c7 into kubernetes:release-1.15 Aug 9, 2019

23 checks passed

cla/linuxfoundation tao12345666333 authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Job succeeded.
Details
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Skipped.
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Skipped.
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Job succeeded.
Details
tide In merge pool.
Details

Release Engineering automation moved this from In progress to Done (1.16) Aug 9, 2019

@tao12345666333 tao12345666333 deleted the tao12345666333:update-go-for-1.15 branch Aug 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.