Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove github.com/kardianos/osext #80142

Merged
merged 1 commit into from Jul 16, 2019

Conversation

@loqutus
Copy link
Contributor

commented Jul 14, 2019

/kind cleanup

What this PR does / why we need it:
This PR removes deprecated dependency github.com/kardianos/osext
Which issue(s) this PR fixes:

Fixes #80127

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Remove deprecated github.com/kardianos/osext dependency
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

Hi @loqutus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@loqutus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

/assign @thockin

@dims

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

/ok-to-test

@loqutus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

/retest

@@ -45,8 +45,6 @@ import (
"k8s.io/kubernetes/test/e2e/framework/testfiles"
"k8s.io/kubernetes/test/e2e/generated"
"k8s.io/kubernetes/test/e2e_node/services"

This comment has been minimized.

Copy link
@BenTheElder

BenTheElder Jul 14, 2019

Member

Removing this blank line sepetating groups of imports requires the imports to be sorted, which fails gofmt.

We should leave this line.

@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

Please run hack/update-vendor.sh, removing this dependency should also remove it from vendor.

@k8s-ci-robot k8s-ci-robot added size/S and removed size/XS labels Jul 14, 2019

@loqutus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 14, 2019

/retest

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

@loqutus LGTM, but please squash your commits.

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 14, 2019

/assign

@draveness
Copy link
Member

left a comment

/priority important-soon

@loqutus

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@cblecker squashed

@cblecker

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

/lgtm
/approve

/unassign thockin
/assign @liggitt
(Tim is on vacation)

@dims

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

👍

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 16, 2019

/approve

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, loqutus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit fe04041 into kubernetes:master Jul 16, 2019

23 checks passed

cla/linuxfoundation loqutus authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.