Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds kubeadm feature-gate for dual-stack (IPv6DualStack) #80145

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@Arvinderpal
Copy link
Contributor

commented Jul 14, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds the dual-stack feature gate to kubeadm. We need to isolate the forthcoming dual-stack related changes to kubeadm.

Special notes for your reviewer:
This is the first of several PRs that will bring dual-stack specific changes to kubeadm. For a complete list of kubeadm changes, see the tracking issue: kubernetes/kubeadm#1612

Does this PR introduce a user-facing change?:

kubeadm ClusterConfiguration now supports featureGates: IPv6DualStack: true

@neolit123 @yastij @fabriziopandini @aojea

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 14, 2019

Hi @Arvinderpal. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@neolit123
Copy link
Member

left a comment

thanks @Arvinderpal , added one comment about importing /pkg

@kubernetes/sig-cluster-lifecycle-pr-reviews
/priority important-longterm

i requested this PR and it only serves the purpose of adding the FG + release note.

Show resolved Hide resolved cmd/kubeadm/app/features/features.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/features/features.go Outdated
Show resolved Hide resolved cmd/kubeadm/app/features/features.go Outdated

@Arvinderpal Arvinderpal force-pushed the Nordix:kubeadm-ds-feature-gate branch from 2117142 to 79e7a4c Jul 15, 2019

@Arvinderpal

This comment has been minimized.

Copy link
Contributor Author

commented Jul 15, 2019

@neolit123 @yastij
I made the requested changes.

@Arvinderpal Arvinderpal referenced this pull request Jul 15, 2019

Open

Dual-Stack support for Kubeadm #1612

4 of 8 tasks complete
@fabriziopandini

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

/ok-to-test
I'm still not 100% convinced we need a dual-stack flag as per comment #79033 (review).
However, If the majority is ok with this, I'm fine with that.

@neolit123

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

/hold

@fabriziopandini

I'm still not 100% convinced we need a dual-stack flag as per comment #79033 (review).

Kubeadm feature flags are different from components feature flags.
I don't think we should add a new feature flag in kubeadm specific for dual stack; nevertheless, I would like to add a validation check that ensures the configuration is consistent in case that when the users opt-in into dual stack, or blocks if the users are providing inconsistent configurations. e.g. Pass if there are two subnets in all the required settings, feature flags are enabled for core components etcd.

so instead of the kubeadm FG, we should tell the users (document) how to enable it by passing the k8s FG to all the required components?

@Arvinderpal which components are going to support the k8s FG?
(my guess is all of them?)

@neolit123
Copy link
Member

left a comment

/lgtm
/approve
/hold cancel

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Arvinderpal, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 768acf6 into kubernetes:master Jul 15, 2019

23 checks passed

cla/linuxfoundation Arvinderpal authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details

@neolit123 neolit123 referenced this pull request Jul 16, 2019

Merged

Dual-Stack Integration with Kubeadm #79033

1 of 1 task complete

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 24, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG (if set) to the individual k8s
components on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 24, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG (if set) to the individual k8s
components on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 24, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG (if set) to the individual k8s
components on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 24, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG (if set) to the individual k8s
components on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 25, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG (if set) to the individual k8s
components on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 29, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 29, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 29, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 30, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 30, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612

Arvinderpal added a commit to Nordix/kubernetes that referenced this pull request Jul 30, 2019

Kubeadm FG for dual-stack was introduced in kubernetes#80145. This PR
progagates the kubeadm FG to the individual k8scomponents
on the control-plane node.

* Note: Users who want to join worker nodes to the cluster
will have to specify the dual-stack FG to kubelet using the
nodeRegistration.kubeletExtraArgs option as part of their
join config. Alternatively, they can use KUBELET_EXTRA_ARGS.

kubeadm FG: kubernetes/kubeadm#1612
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.