Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove manual conversions for ListOptions #80157

Merged
merged 1 commit into from Jul 15, 2019

Conversation

@wojtek-t
Copy link
Member

commented Jul 15, 2019

Manual conversions for ListOptions wasn't copying the AllowWatchBookmark fields (and thus the feature doesn't work without this change).

Ref #73585
Ref kubernetes/enhancements#956

Fix a bug that ListOptions.AllowWatchBookmarks wasn't propagating correctly in kube-apiserver.
@wojtek-t wojtek-t force-pushed the wojtek-t:remove_static_conversions branch from 03367bc to 6ad86a7 Jul 15, 2019
@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

/retest

@fejta-bot

This comment has been minimized.

Copy link

commented Jul 15, 2019

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

based on the auto-generated function, I don't see any reason for a manually written one. do we know why it was introduced in the first place?

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 15, 2019

/lgtm
/approve

/hold
I don't see any issues with this, but would like to know what the reason for it being added was, to make sure we don't introduce any issues

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wojtek-t

This comment has been minimized.

Copy link
Member Author

commented Jul 15, 2019

@liggitt - it was created by @smarterclayton in #40178
It was part of moving ListOptions to meta api group - my guess would be that there wasn't any bigger thought behind by, but we can wait for @smarterclayton - to confirm?

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

I think this is just historical. At the time the generators didn't work for internal versions outside of k8s.io/kubernetes I believe.

/lgtm
/hold cancel

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

/hold

I want to verify that Convert is called.

@smarterclayton

This comment has been minimized.

Copy link
Contributor

commented Jul 15, 2019

Yeah, this was a bug in the generator before.

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm and removed do-not-merge/hold labels Jul 15, 2019
@fejta-bot

This comment has been minimized.

Copy link

commented Jul 15, 2019

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 635b83c into kubernetes:master Jul 15, 2019
20 of 23 checks passed
20 of 23 checks passed
pull-kubernetes-bazel-build Job triggered.
Details
pull-kubernetes-bazel-test Job triggered.
Details
pull-kubernetes-typecheck Job triggered.
Details
cla/linuxfoundation wojtek-t authorized
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@wojtek-t wojtek-t deleted the wojtek-t:remove_static_conversions branch Jul 19, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
k8s-ci-robot added a commit that referenced this pull request Aug 7, 2019
#80236-upstream-release-1.15

Automated cherry pick of #80157 #80236 upstream release 1.15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.