Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Clarify use of node-role labels within Kubernetes #80238
Node role labels were not intended for use internal to Kubernetes components because they are not required for conformant clusters. Replace uses with implementations that match the linked KEP.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: smarterclayton
The full list of commands accepted by this bot can be found here.
The pull request process is described here
1 similar comment
This gate will default to on in 1.16 to cover the behavior of the existing system, and then in the future default to off and then be removed once all consumers have migrated.
The service load balancer controller should honor the LegacyNodeRoleBehavior feature gate for checks that use node-roles, switch to using a non alpha annotation behind the gate, and prepare to graduate to beta.
The current mechanism for excluding "master" nodes based on node names is fragile and should be fixed by using a label exclusion similar to service load balancers. The legacy code path is preserved behind a defaulted-on gate and will be removed in the future.