New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurately get hardware cpu count in Vagrantfile. #8024

Merged
merged 1 commit into from May 11, 2015

Conversation

Projects
None yet
4 participants
@BenTheElder
Member

BenTheElder commented May 9, 2015

In Vagrantfile replace hack that assumed hyper threading was enabled on
the host and divided ncpu by 2 with methods of getting the actual
hardware core count.

Accurately get hardware cpu count in Vagrantfile.
In Vagrantfile replace hack that assumed hyper threading was enabled on
the host and divided ncpu by 2 with methods of getting the actual
hardware core count.

@googlebot googlebot added the cla: yes label May 9, 2015

@BenTheElder

This comment has been minimized.

Show comment
Hide comment
@BenTheElder

BenTheElder May 9, 2015

Member

I have a pretty fast 4 core intel proc (i5-2500k @ 4.2ghz turbo) without hyperthreading enabled so when I spotted the copy-pasta here assuming hyperthreading I whipped up a quick fix. Tested on Yosemite (on a laptop that does have hyperthreading) and Fedora 21 but should be quite portable, did a little googling to find some methods of getting physical core count. Not sure about the best solution for windows so I left that as is.

Member

BenTheElder commented May 9, 2015

I have a pretty fast 4 core intel proc (i5-2500k @ 4.2ghz turbo) without hyperthreading enabled so when I spotted the copy-pasta here assuming hyperthreading I whipped up a quick fix. Tested on Yosemite (on a laptop that does have hyperthreading) and Fedora 21 but should be quite portable, did a little googling to find some methods of getting physical core count. Not sure about the best solution for windows so I left that as is.

@zmerlynn

This comment has been minimized.

Show comment
Hide comment
@zmerlynn

zmerlynn May 9, 2015

Member

LGTM

Member

zmerlynn commented May 9, 2015

LGTM

@zmerlynn zmerlynn added the lgtm label May 9, 2015

jszczepkowski added a commit that referenced this pull request May 11, 2015

Merge pull request #8024 from BenTheElder/vagrant_cpu_count
Accurately get hardware cpu count in Vagrantfile.

@jszczepkowski jszczepkowski merged commit 54e0f46 into kubernetes:master May 11, 2015

4 checks passed

Shippable Shippable builds completed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 48.78%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment