Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Failure logging #80253
What type of PR is this?
What this PR does / why we need it:
Logging of failed assertions in E2E testing is inconsistent and sub-optimal:
This made debugging a test with long-running cleanup code problematic.
Special notes for your reviewer:
This PR is split into an introduction of a unit test that demonstrates the current status followed by individual commits that address these shortcomings. The effect of each change can be seen in the corresponding change of the unit test.
Does this PR introduce a user-facing change?:
3 times, most recently
Jul 22, 2019
[APPROVALNOTIFIER] This PR is APPROVED
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing
Aug 26, 2019
21 of 24 checks passed
@pohly: The following test failed, say