Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: cleanup pod critical pod annotations feature" #80277

Merged

Conversation

@draveness
Copy link
Member

commented Jul 18, 2019

/kind bug
/priority critical-urgent
/sig scheduling

What this PR does / why we need it:

Remove pod critical pod annotations cause regression for static pod.

Which issue(s) this PR fixes:

ref: #80203 #79548

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Revert "scheduler.alpha.kubernetes.io/critical-pod annotation is removed. Pod priority (spec.priorityClassName) should be used instead to mark pods as critical. Action required!"

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

/assign @bsalamat

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

@bsalamat

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 18, 2019
@BenTheElder

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

/approve

@liggitt

This comment has been minimized.

Copy link
Member

commented Jul 18, 2019

/approve

Please strike the release note from the previous PR to avoid confusion

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BenTheElder, bsalamat, draveness, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

Thank you all for quick responding!

This reverts commit b6d41ee.
@draveness draveness force-pushed the draveness:feature/revert-cleanup-critical-pod branch from edf59e6 to d83526d Jul 18, 2019
@k8s-ci-robot k8s-ci-robot removed the lgtm label Jul 18, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 18, 2019

Rebased due to file pkg/features/kube_features.go conflicted with master.

@bsalamat

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm label Jul 19, 2019
@k8s-ci-robot k8s-ci-robot merged commit 49f6510 into kubernetes:master Jul 19, 2019
23 checks passed
23 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@draveness draveness deleted the draveness:feature/revert-cleanup-critical-pod branch Jul 19, 2019
mboersma added a commit to mboersma/aks-engine that referenced this pull request Jul 31, 2019
The change itself was removed in Kubernetes 1.16.0-alpha.2.
See kubernetes/kubernetes#80277
@mboersma mboersma referenced this pull request Jul 31, 2019
2 of 5 tasks complete
jackfrancis added a commit to Azure/aks-engine that referenced this pull request Jul 31, 2019
* feat: add support for Kubernetes 1.16.0-alpha.2

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.16.md#changelog-since-v1160-alpha1

* revert: "fix: Remove pod-critical annotations in 1.16 manifests"

The change itself was removed in Kubernetes 1.16.0-alpha.2.
See kubernetes/kubernetes#80277
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.