Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove deprecated include uninitialized flag #80337

Conversation

@draveness
Copy link
Member

commented Jul 19, 2019

/kind cleanup
/priority backlog

What this PR does / why we need it:

Remove deprecated include uninitialized flag which should be removed in 1.15

Does this PR introduce a user-facing change?:

Remove deprecated "include-uninitialized" flag. action required

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@draveness

This comment has been minimized.

Copy link
Member Author

commented Jul 19, 2019

/assign @soltysh

@dixudx
dixudx approved these changes Aug 4, 2019
Copy link
Member

left a comment

Thanks for cleaning it up.

/lgtm

@dixudx

This comment has been minimized.

Copy link
Member

commented Aug 4, 2019

@draveness Please rebase it. Thanks.

@draveness draveness force-pushed the draveness:feature/remove-deprecated-include-uninitialized-flag branch from 8ca4c31 to e7bd6a0 Aug 4, 2019
@draveness draveness force-pushed the draveness:feature/remove-deprecated-include-uninitialized-flag branch from e7bd6a0 to f18f86a Aug 4, 2019
@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

@draveness Please rebase it. Thanks.

Please take another look.

@draveness

This comment has been minimized.

Copy link
Member Author

commented Aug 4, 2019

/retest

@soltysh
soltysh approved these changes Sep 9, 2019
Copy link
Contributor

left a comment

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm label Sep 9, 2019
@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: draveness, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit bd6f58c into kubernetes:master Sep 10, 2019
23 checks passed
23 checks passed
cla/linuxfoundation draveness authorized
Details
pull-kubernetes-bazel-build Job succeeded.
Details
pull-kubernetes-bazel-test Job succeeded.
Details
pull-kubernetes-conformance-image-test Skipped.
pull-kubernetes-cross Skipped.
pull-kubernetes-dependencies Job succeeded.
Details
pull-kubernetes-e2e-gce Job succeeded.
Details
pull-kubernetes-e2e-gce-100-performance Job succeeded.
Details
pull-kubernetes-e2e-gce-csi-serial Skipped.
pull-kubernetes-e2e-gce-device-plugin-gpu Job succeeded.
Details
pull-kubernetes-e2e-gce-iscsi Skipped.
pull-kubernetes-e2e-gce-iscsi-serial Skipped.
pull-kubernetes-e2e-gce-storage-slow Skipped.
pull-kubernetes-godeps Skipped.
pull-kubernetes-integration Job succeeded.
Details
pull-kubernetes-kubemark-e2e-gce-big Job succeeded.
Details
pull-kubernetes-local-e2e Skipped.
pull-kubernetes-node-e2e Job succeeded.
Details
pull-kubernetes-node-e2e-containerd Job succeeded.
Details
pull-kubernetes-typecheck Job succeeded.
Details
pull-kubernetes-verify Job succeeded.
Details
pull-publishing-bot-validate Skipped.
tide In merge pool.
Details
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Sep 10, 2019
@draveness draveness deleted the draveness:feature/remove-deprecated-include-uninitialized-flag branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.